Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Google Ads: Remove metrics from ad group for manager account #34212

Merged

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Jan 12, 2024

What

Resolved:#33494 (comment)
The update to add a new field to the ad_group stream is leading to errors for users with the connector set up using a manager account. This is because metrics are not accessible for manager accounts

How

Removed metrics.cost_micros from Ad Group Stream query for manager account.

🚨 User Impact 🚨

Users with manager account will sync Ad Group stream without query error.

@darynaishchenko darynaishchenko self-assigned this Jan 12, 2024
Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2024 0:44am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 12, 2024
Copy link
Contributor

github-actions bot commented Jan 12, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested review from a team January 12, 2024 11:40
@darynaishchenko darynaishchenko changed the title 🚨🚨: Source Google Ads: Remove metrics from ad group 🚨🚨 Source Google Ads: Remove metrics from ad group Jan 12, 2024
@darynaishchenko darynaishchenko added the breaking-change Don't merge me unless you are ready. label Jan 12, 2024
@tolik0
Copy link
Contributor

tolik0 commented Jan 12, 2024

@darynaishchenko, Could you please add a unit test to check if non-manager streams don't have metrics in fields to avoid such issues in the future?

@darynaishchenko
Copy link
Collaborator Author

@darynaishchenko, Could you please add a unit test to check if non-manager streams don't have metrics in fields to avoid such issues in the future?

@tolik0 test was added

@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 12, 2024 14:57
@darynaishchenko darynaishchenko force-pushed the daryna/source-google-ads/remove-metrics-from-ad-group branch from 87f55a5 to fc1a487 Compare January 12, 2024 18:12
@darynaishchenko darynaishchenko changed the title 🚨🚨 Source Google Ads: Remove metrics from ad group 🐛 Source Google Ads: Remove metrics from ad group for manager account Jan 12, 2024
@darynaishchenko darynaishchenko removed the breaking-change Don't merge me unless you are ready. label Jan 12, 2024
@darynaishchenko darynaishchenko requested review from tolik0 and removed request for a team January 12, 2024 18:15
@darynaishchenko darynaishchenko merged commit 5380d23 into master Jan 15, 2024
24 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-google-ads/remove-metrics-from-ad-group branch January 15, 2024 13:08
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants