-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Google Ads: Remove metrics from ad group for manager account #34212
🐛 Source Google Ads: Remove metrics from ad group for manager account #34212
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@darynaishchenko, Could you please add a unit test to check if non-manager streams don't have metrics in fields to avoid such issues in the future? |
@tolik0 test was added |
airbyte-integrations/connectors/source-google-ads/metadata.yaml
Outdated
Show resolved
Hide resolved
87f55a5
to
fc1a487
Compare
What
Resolved:#33494 (comment)
The update to add a new field to the ad_group stream is leading to errors for users with the connector set up using a manager account. This is because metrics are not accessible for manager accounts
How
Removed metrics.cost_micros from Ad Group Stream query for manager account.
🚨 User Impact 🚨
Users with manager account will sync Ad Group stream without query error.