-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: compute GHA runs-on
from --ci-requirements
#34220
airbyte-ci: compute GHA runs-on
from --ci-requirements
#34220
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
In this stack:
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
18552bb
to
9087f08
Compare
f73a63c
to
08e88e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Testing GHA is always tricky, but this looks right to me.
I think maybe a note should be added in the docs that all N of the actions that run stuff with airbyte-ci will dynamically choose which runner to work on based on this (link to python code)
f897de6
to
2f81a55
Compare
211409e
to
88c7b9e
Compare
I updated the command documentation in #34218 |
5cadcb2
to
0e0f356
Compare
e2a980a
to
2a14f08
Compare
0876dde
to
9a404b6
Compare
What
Closes #34076
We want to dynamically determine the self hosted CI runner to use according to the output of
--ci-requirements
How
airbyte-ci-requirements
action: it will run--ci-requirements
on inputted commands, on a github hosted ubuntu runner.runs-on
field).