fix precommit format to ignore new airbyte-ci versions #34234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
alafanechere
approved these changes
Jan 15, 2024
stephane-airbyte
deleted the
stephane/01-12-fix_precommit_format_to_ignore_new_airbyte-ci_versions
branch
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
if there's a new version of airbyte-ci available, we fail the pre-push hook and force an update. For some reason, that doesn't even satisfy pre-push hooks on graphite. I really think it's an unnecessary check during hooks, and only adds friction
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
if there's a new version of airbyte-ci available, we fail the pre-push hook and force an update. For some reason, that doesn't even satisfy pre-push hooks on graphite. I really think it's an unnecessary check during hooks, and only adds friction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there's a new version of airbyte-ci available, we fail the pre-push hook and force an update. For some reason, that doesn't even satisfy pre-push hooks on graphite. I really think it's an unnecessary check during hooks, and only adds friction