Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Source Amazon Seller Partner: delete deprecated streams #34283

Merged

Conversation

askarpets
Copy link
Contributor

What

Based on the docs, the following two streams are deprecated and should be deleted:

  • GET_BRAND_ANALYTICS_ITEM_COMPARISON_REPORT
  • GET_BRAND_ANALYTICS_ALTERNATE_PURCHASE_REPORT

Recommended reading order

  1. streams.py
  2. source.py

🚨 User Impact 🚨

This is NOT a breaking change as there are no active customers for the streams listed above.

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@askarpets askarpets self-assigned this Jan 16, 2024
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 1:22pm

Copy link

sweep-ai bot commented Jan 16, 2024

Apply Sweep Rules to your PR?

This is an automated message generated by Sweep AI.

Copy link

sweep-ai bot commented Jan 16, 2024

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run echo "::error::All checklist items not checked. Review your PR description and comments for unchecked items."
yielded the following error:
##[error]All checklist items not checked. Review your PR description and comments for unchecked items.
##[error]Process completed with exit code 1.
##[group]Run mheap/require-checklist-action@v2
with:
  requireChecklist: false
  token: ***
  skipComments: false
##[endgroup]
Incomplete task list item: **Apply:**  All new business logic should have corresponding unit tests.
Incomplete task list item: **Apply:**  Refactor large functions to be more modular.
Incomplete task list item: **Apply:**  Add docstrings to all functions and file headers.
##[error]The following items are not marked as completed: **Apply:**  All new business logic should have corresponding unit tests., **Apply:**  Refactor large functions to be more modular., **Apply:**  Add docstrings to all functions and file headers.

Here are the logs:


[!CAUTION]

An error has occurred: Cmd('git') failed due to: exit code(128)
cmdline: git clone -v --branch=source-amazon-seller-partner-delete-deprecated-streams -- https://:@github.com/airbytehq/airbyte.git /tmp/cache/repos/airbytehq/airbyte/base/source-amazon-seller-partner-delete-deprecated-streams
stderr: 'Cloning into '/tmp/cache/repos/airbytehq/airbyte/base/source-amazon-seller-partner-delete-deprecated-streams'...
POST git-upload-pack (652 bytes)
POST git-upload-pack (gzip 136317 to 67293 bytes)
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
' (tracking ID: 4d27036265)

Copy link

sweep-ai bot commented Jan 16, 2024

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run echo "::error::All checklist items not checked. Review your PR description and comments for unchecked items."
yielded the following error:
##[error]All checklist items not checked. Review your PR description and comments for unchecked items.
##[error]Process completed with exit code 1.
##[group]Run mheap/require-checklist-action@v2
with:
  requireChecklist: false
  token: ***
  skipComments: false
##[endgroup]
Incomplete task list item: **Apply:**  All new business logic should have corresponding unit tests.
Incomplete task list item: **Apply:**  Refactor large functions to be more modular.
Incomplete task list item: **Apply:**  Add docstrings to all functions and file headers.
##[error]The following items are not marked as completed: **Apply:**  All new business logic should have corresponding unit tests., **Apply:**  Refactor large functions to be more modular., **Apply:**  Add docstrings to all functions and file headers.

Here are the logs:


[!CAUTION]

An error has occurred: Cmd('git') failed due to: exit code(128)
cmdline: git clone -v --branch=source-amazon-seller-partner-delete-deprecated-streams -- https://:@github.com/airbytehq/airbyte.git /tmp/cache/repos/airbytehq/airbyte/base/source-amazon-seller-partner-delete-deprecated-streams
stderr: 'Cloning into '/tmp/cache/repos/airbytehq/airbyte/base/source-amazon-seller-partner-delete-deprecated-streams'...
POST git-upload-pack (652 bytes)
POST git-upload-pack (gzip 136317 to 67293 bytes)
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
' (tracking ID: 660dae9526)

Copy link

sweep-ai bot commented Jan 16, 2024

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run echo "::error::All checklist items not checked. Review your PR description and comments for unchecked items."
yielded the following error:
##[error]All checklist items not checked. Review your PR description and comments for unchecked items.
##[error]Process completed with exit code 1.
##[group]Run mheap/require-checklist-action@v2
with:
  requireChecklist: false
  token: ***
  skipComments: false
##[endgroup]
Incomplete task list item: **Apply:**  All new business logic should have corresponding unit tests.
Incomplete task list item: **Apply:**  Refactor large functions to be more modular.
Incomplete task list item: **Apply:**  Add docstrings to all functions and file headers.
##[error]The following items are not marked as completed: **Apply:**  All new business logic should have corresponding unit tests., **Apply:**  Refactor large functions to be more modular., **Apply:**  Add docstrings to all functions and file headers.

Here are the logs:


[!CAUTION]

An error has occurred: Cmd('git') failed due to: exit code(128)
cmdline: git clone -v --branch=source-amazon-seller-partner-delete-deprecated-streams -- https://:@github.com/airbytehq/airbyte.git /tmp/cache/repos/airbytehq/airbyte/base/source-amazon-seller-partner-delete-deprecated-streams
stderr: 'Cloning into '/tmp/cache/repos/airbytehq/airbyte/base/source-amazon-seller-partner-delete-deprecated-streams'...
POST git-upload-pack (652 bytes)
POST git-upload-pack (gzip 136317 to 67293 bytes)
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
' (tracking ID: 5866c7bc77)

Copy link
Contributor

github-actions bot commented Jan 16, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested review from a team January 16, 2024 08:19
Copy link
Collaborator

@artem1205 artem1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please bump Minor version instead of Patch

@askarpets askarpets merged commit a6f4c2e into master Jan 17, 2024
28 of 29 checks passed
@askarpets askarpets deleted the source-amazon-seller-partner-delete-deprecated-streams branch January 17, 2024 13:56
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-seller-partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants