Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Source-mongodb-v2] : Adding logs for resume token timestamps + reducing min document discovery size further #34364

Merged
merged 10 commits into from
Jan 19, 2024
Merged

[Source-mongodb-v2] : Adding logs for resume token timestamps + reducing min document discovery size further #34364

merged 10 commits into from
Jan 19, 2024

Conversation

akashkulk
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 0:25am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit labels Jan 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024 •
edited by akashkulk
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@akashkulk akashkulk marked this pull request as ready for review January 18, 2024 21:53
@akashkulk akashkulk requested a review from rodireich January 18, 2024 21:53
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Jan 18, 2024
rodireich
rodireich reviewed Jan 18, 2024
View reviewed changes
airbyte-integrations/connectors/source-mongodb-v2/build.gradle Outdated
@@ -7,7 +7,7 @@ plugins {
airbyteJavaConnector {
cdkVersionRequired = '0.7.9'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on 13 or 14 already I think

@akashkulk
Copy link
Contributor Author

akashkulk commented Jan 18, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7577067902
❌ Publish Java CDK version=0.13.1 failed!

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 18, 2024
@akashkulk
Copy link
Contributor Author

akashkulk commented Jan 18, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7577356815
✅ Successfully published Java CDK version=0.13.2!

@akashkulk akashkulk merged commit 25a0c80 into master Jan 19, 2024
26 checks passed
@akashkulk akashkulk deleted the akash/mongo-hh branch January 19, 2024 00:38
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@akashkulk @jatinyadav-cc
[Source-mongodb-v2] : Adding logs for resume token timestamps + reduc…
9e42e80 
…ing min document discovery size further (airbytehq#34364)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@akashkulk @jatinyadav-cc
[Source-mongodb-v2] : Adding logs for resume token timestamps + reduc…
45790c6 
…ing min document discovery size further (airbytehq#34364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/mongodb-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akashkulk @rodireich @octavia-squidington-iii