Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Postgres: DV2 Beta #34372

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Destination Postgres: DV2 Beta #34372

merged 1 commit into from
Jan 22, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 19, 2024 •
edited
Loading

What

  • Adding postgres DV2 beta launch option

@vercel Vercel
Copy link

vercel bot commented Jan 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 3:34am

@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jan 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024 •
edited by gisripa
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@gisripa gisripa marked this pull request as ready for review January 19, 2024 00:42
@gisripa gisripa requested a review from a team as a code owner January 19, 2024 00:42
edgao
edgao approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc you also need to update https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/destination-postgres-strict-encrypt/src/test/resources/expected_spec.json

@gisripa gisripa force-pushed the postgres/dv2-spec-changes branch from 5f2854e to e43c754 Compare January 19, 2024 00:55
@gisripa gisripa changed the title adding 1st_1t flag Destination Postgres: DV2 Beta Jan 19, 2024
@gisripa gisripa force-pushed the postgres/dv2-spec-changes branch 2 times, most recently from d406ad4 to f3ca61b Compare January 19, 2024 20:36
@gisripa gisripa force-pushed the postgres/dv2-spec-changes branch from f3ca61b to 7585e63 Compare January 19, 2024 20:40
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 19, 2024
@gisripa gisripa force-pushed the postgres/dv2-spec-changes branch from 7585e63 to 65afbb1 Compare January 19, 2024 20:49
@gisripa
Copy link
Contributor Author

gisripa commented Jan 19, 2024

Sync running with Dev image. Connection was earlier running v1. Now v2 enabled.

@gisripa gisripa force-pushed the postgres/dv2-spec-changes branch from 65afbb1 to ad6d09b Compare January 22, 2024 03:32
@gisripa
Copy link
Contributor Author

gisripa commented Jan 22, 2024

Previous sync failed due to v1-v2 migration column order mismatch. This succeeded https://cloud.airbyte.com/workspaces/2c817306-57f8-4b59-bf34-d8784680946c/connections/a7cae7a3-6b2a-4253-b68e-d8662544572e/job-history

@gisripa gisripa self-assigned this Jan 22, 2024
@gisripa gisripa merged commit 6b4f215 into master Jan 22, 2024
36 of 37 checks passed
@gisripa gisripa deleted the postgres/dv2-spec-changes branch January 22, 2024 17:07
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Postgres: DV2 Beta (airbytehq#34372)
4a06ad1 
## What
* Adding postgres DV2 beta launch option
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Destination Postgres: DV2 Beta (airbytehq#34372)
a6088a0 
## What
* Adding postgres DV2 beta launch option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees

@gisripa gisripa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/postgres connectors/destination/postgres-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gisripa @edgao @octavia-squidington-iii