CAT: set additionalProperties recursively for objects
#34448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
maxi297
reviewed
Jan 25, 2024
airbyte-integrations/bases/connector-acceptance-test/unit_tests/test_asserts.py
Outdated
Show resolved
Hide resolved
alafanechere
approved these changes
Jan 29, 2024
| @@ -67,7 +90,7 @@ def verify_records_schema( | |||
| for stream in catalog.streams: | |||
| schema_to_validate_against = stream.stream.json_schema | |||
| if fail_on_extra_columns: | |||
| schema_to_validate_against = _enforce_no_additional_top_level_properties(schema_to_validate_against) | |||
| schema_to_validate_against = _enforce_false_additional_properties(schema_to_validate_against) | |||
There was a problem hiding this comment.
I would find it more elegant to implement a custom Validator class which would enforce additional properties to false.
There was a problem hiding this comment.
agreed, moved schema transformation inside validator class
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve #32191
How
Set
additionalPropertiesrecursively for objects inside jsonschema.Skip objects if no properties are mentioned.
Recommended reading order
airbyte-integrations/bases/connector-acceptance-test/connector_acceptance_test/utils/asserts.pyairbyte-integrations/bases/connector-acceptance-test/unit_tests/test_asserts.py🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.