Destinations snowflake, bigquery, redshift: improve error reporting (lowercase before deinterpolation) #34458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edgao
force-pushed
the
edgao/cdk/exception_grouping
branch
from
0959513 to
12649f0
Compare
evantahler
approved these changes
Jan 24, 2024
octavia-squidington-iii
added
area/connectors
edgao
force-pushed
the
edgao/cdk/exception_grouping
branch
from
03a3fbd to
739354b
Compare
# Conflicts: # airbyte-cdk/java/airbyte-cdk/README.md
octavia-squidington-iii
added
area/documentation
|
/publish-java-cdk
|
edgao
changed the title
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of https://github.com/airbytehq/airbyte-internal-issues/issues/2358. Lowercase everything before deinterpolation, to avoid snowflake's upcasing nonsense.
This won't handle e.g. quoting differences (
THE_TABLEvs"THE_TABLE"), but it at least helps.