Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigquery Destination: CDK Update #34468

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Bigquery Destination: CDK Update #34468

merged 7 commits into from
Jan 24, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented Jan 24, 2024

What

  • Upgrade to latest CDK with signature changes.

@gisripa gisripa requested a review from a team as a January 24, 2024 01:56
@vercel Vercel
Copy link

vercel bot commented Jan 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 9:20pm

@gisripa gisripa mentioned this pull request Jan 24, 2024
Merged
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 24, 2024
@gisripa gisripa mentioned this pull request Jan 24, 2024
Merged
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jan 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa mentioned this pull request Jan 24, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited by gisripa
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@gisripa gisripa force-pushed the gireesh/01-23-bigquery/cdk-update branch from 2563c25 to 8b06143 Compare January 24, 2024 17:15
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 24, 2024
@gisripa gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 6e46415 to 1171ebc Compare January 24, 2024 17:17
@gisripa gisripa force-pushed the gireesh/01-23-bigquery/cdk-update branch from a9243c1 to 97d9a37 Compare January 24, 2024 17:17
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 24, 2024 17:18
Base automatically changed from gireesh/01-23-gireesh/cdk/resurrect-breaking to master January 24, 2024 18:08
@gisripa gisripa force-pushed the gireesh/01-23-bigquery/cdk-update branch from 97d9a37 to afe4474 Compare January 24, 2024 18:12
@gisripa gisripa force-pushed the gireesh/01-23-bigquery/cdk-update branch from afe4474 to bde52cf Compare January 24, 2024 18:48
cynthiaxyin
cynthiaxyin approved these changes Jan 24, 2024
View reviewed changes
...bigquery/src/main/java/io/airbyte/integrations/destination/bigquery/BigQueryDestination.java
@@ -457,6 +457,11 @@ private TyperDeduper buildTyperDeduper(final BigQuerySqlGenerator sqlGenerator,

}

@Override
public boolean isV2Destination() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :D

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 24, 2024
@gisripa
Copy link
Contributor Author

gisripa commented Jan 24, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7646228421
✅ Successfully published Java CDK version=0.14.1!

@cynthiaxyin cynthiaxyin mentioned this pull request Jan 24, 2024
Closed
@gisripa gisripa merged commit c42c5e6 into master Jan 24, 2024
24 checks passed
@gisripa gisripa deleted the gireesh/01-23-bigquery/cdk-update branch January 24, 2024 21:37
@gisripa Graphite App
Copy link
Contributor Author

gisripa commented Jan 24, 2024

Merge activity

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@gisripa @jatinyadav-cc
Bigquery Destination: CDK Update (airbytehq#34468)
334f736 
## What
* Upgrade to latest CDK with signature changes.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Bigquery Destination: CDK Update (airbytehq#34468)
ed5ac22 
## What
* Upgrade to latest CDK with signature changes.
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@gisripa @jatinyadav-cc
Bigquery Destination: CDK Update (airbytehq#34468)
a668f6c 
## What
* Upgrade to latest CDK with signature changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cynthiaxyin cynthiaxyin cynthiaxyin approved these changes

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit checklist-action-run connectors/destination/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gisripa @edgao @cynthiaxyin @octavia-squidington-iii