airbyte-lib: Lightweight validation #34475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
aaronsteers
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Looks good! Approved for my part.
Long-term, I'd love for these to live inside CAT, but importantly that probably requires (1) that CAT be more portable and (2) that CAT has options to run a subset of checks. Maybe in another thread, we can discuss the long-term path here. I'm not familiar enough with CAT to make any suggestions or know what is feasible there.
|
I have a PR to integrate it into airbyte-ci so it can be run in an automated way: #34044. CAT is pretty hard-wired on docker, that's why it's difficult that way. |
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable us to publish the long tail of python connectors without running the full test suite, this PR prepares the most basic smoketest:
This will give us enough confidence for the initial publish as it eliminates a lot of error classes that render the connector completely unusable.
There are still some scenarios that could lead to broken connectors being shipped like this (e.g. lazily loaded modules cause an error, API changes rendered the connector useless), but this risk is accepted.
Drive-by change
I noticed an issue with
airbyte_messages_to_record_dicts- its types state that it returns a iterator of dicts, but it will return none if an emitted message is not a record message. I fixed this by not emitting anything in this case (this broke the validation logic if the first airbyte message returned from the connector is not a record).