-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weaviate: Fix tests #34529
Weaviate: Fix tests #34529
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. 👍
I'm also okay with merging without a version bump or re-publish, since it doesn't change anything in the shipped code. (I don't feel strongly either way.)
Tests for destination-weaviate started failing due to the most recent release of
pytest-docker
, pinning the latest one:https://pypi.org/project/pytest-docker/#history
From test failures: