AirbyteLib: Case insensitive missing column checks, deterministic column ordering in duckdb inserts #34824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This was not the root cause of the issue we ran into. Closing this PR but we can re-open if we see the symptom addressed here. The actual issue was a catalog bug on the source connector side, which gets resolved here: |
|
Reopening, in case this issue is perhaps related to: |
aaronsteers
changed the title
aaronsteers
force-pushed
the
aj/airbyte-lib/case-insensitive-missing-col-check
branch
from
0febed7 to
cb73700
Compare
aaronsteers
deleted the
aj/airbyte-lib/case-insensitive-missing-col-check
branch
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
…umn ordering in duckdb inserts (#34824)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
…umn ordering in duckdb inserts (airbytehq#34824)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…umn ordering in duckdb inserts (airbytehq#34824)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…umn ordering in duckdb inserts (airbytehq#34824)
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
…umn ordering in duckdb inserts (#34824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses case-insensitive comparisons when checking for missing columns. We also use an explicit column ordering for duckdb inserts, so that randomized column orders do not break the column aligment during insert.
Other fixes: