make exclusive containers first class citizens

[stephane-airbyte]

Very heavily lifted from #34865

Originally, the db-source's ContainerFactory test fixture was built under the assumption that testcontainers could always be shared by multiple tests. In practice it turns out that that's not always the case, especially for CDC tests where the CDC state is at the RDBMS level. For instance, in mysql, there's only one binlog.

Recently we struggled to debug an issue because an unshared testcontainer didn't forward its logs to the logging back-end. This is done by default for shared containers, but was forgotten for an unshared container in a CDC test.

Rather than peppering these tests with the suitable logging incantations, this PR adds an exclusive method to ContainerFactory which is like the existing shared except that, well, the container is not shared. This way testcontainers are provisioned in the same way regardless of whether they're shared or not.
While doing that, I took the opportunity to simplify the existing code

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Feb 7, 2024 8:46pm

[stephane-airbyte]

• master
  • make exclusive containers first class citizens #34892 👈

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite

[github-actions]

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

• PR name follows PR naming conventions
• Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
• Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
• You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
• Secrets in the connector's spec are annotated with airbyte_secret
• All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
• Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
• Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
• If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

1. Check for hidden checklists in your PR description

2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

[postamar]

seems simpler this way

[github-actions]

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage	69.34%	🍏

[postamar]

comment needs adjusting

[postamar]

This is much better, thanks for doing this. Considering that mssql is still broken on master feel free to adopt these changes in another source in order to get this to merge.

Can you port over the log message colouring from my PR also? It's actually useful. The commit is 22702c6

[stephane-airbyte]

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/7821132796
✅ Successfully published Java CDK version=0.16.6!