-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Google Analytics Data API: Add spec parameter to convert conversions:purchase
to float
#34907
Merged
tolik0
merged 2 commits into
master
from
tolik0/source-google-analytics-data-api/conversions-purchase-to-float
Feb 6, 2024
Merged
✨ Source Google Analytics Data API: Add spec parameter to convert conversions:purchase
to float
#34907
tolik0
merged 2 commits into
master
from
tolik0/source-google-analytics-data-api/conversions-purchase-to-float
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/source/google-analytics-data-api
labels
Feb 6, 2024
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Feb 6, 2024
bazarnov
approved these changes
Feb 6, 2024
tolik0
deleted the
tolik0/source-google-analytics-data-api/conversions-purchase-to-float
branch
February 6, 2024 17:29
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
…nversions:purchase` to float (#34907)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
…nversions:purchase` to float (airbytehq#34907)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…nversions:purchase` to float (airbytehq#34907)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…nversions:purchase` to float (airbytehq#34907)
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
…nversions:purchase` to float (#34907)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/google-analytics-data-api
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduces the option to convert the
conversions:purchase
column to a float type. This change addresses the issue documented in https://github.com/airbytehq/oncall/issues/4130.How
For some users, Google Analytics API returns float values for the
conversions:purchase
column, which is expected to be an integer. To mitigate data discrepancies caused by rounding float values to integers in the previous connector version, this update introduces a new specification parameter,convert_conversions_purchase
. When activated, this parameter ensures theconversions:purchase
column is treated as a float, preserving the accuracy of the data returned by the API.