Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File based sources fix sync mode bug #34936

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Feb 7, 2024

Bumps the CDK version for file-based sources.

An issue was identified with the S3 connector where some invocations of the stream command were erroring because they had a catalog but no SyncMode.

This issue hasn't been seen in any other connectors, but I'm bumping the version as a precaution.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 0:14am

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks for fixing! ✅ 🚢

@clnoll clnoll merged commit 58de015 into master Feb 7, 2024
27 checks passed
@clnoll clnoll deleted the file-based-sources-fix-sync-mode-bug branch February 7, 2024 00:59
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
Includes:
Source Azure Blob Storage
Source GCS
Source Google Drive
Source Microsoft Onedrive
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
Includes:
Source Azure Blob Storage
Source GCS
Source Google Drive
Source Microsoft Onedrive
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Includes:
Source Azure Blob Storage
Source GCS
Source Google Drive
Source Microsoft Onedrive
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Includes:
Source Azure Blob Storage
Source GCS
Source Google Drive
Source Microsoft Onedrive
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
Includes:
Source Azure Blob Storage
Source GCS
Source Google Drive
Source Microsoft Onedrive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants