-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File based sources fix sync mode bug #34936
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
d51280b
to
6120737
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thanks for fixing! ✅ 🚢
Includes: Source Azure Blob Storage Source GCS Source Google Drive Source Microsoft Onedrive
Includes: Source Azure Blob Storage Source GCS Source Google Drive Source Microsoft Onedrive
Includes: Source Azure Blob Storage Source GCS Source Google Drive Source Microsoft Onedrive
Includes: Source Azure Blob Storage Source GCS Source Google Drive Source Microsoft Onedrive
Includes: Source Azure Blob Storage Source GCS Source Google Drive Source Microsoft Onedrive
Bumps the CDK version for file-based sources.
An issue was identified with the S3 connector where some invocations of the
stream
command were erroring because they had a catalog but noSyncMode
.This issue hasn't been seen in any other connectors, but I'm bumping the version as a precaution.