Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db-sources-java-cdk: fix logic to calculate the state stats count in db sources iterator #34948

Merged
merged 8 commits into from
Feb 7, 2024
Merged

db-sources-java-cdk: fix logic to calculate the state stats count in db sources iterator #34948

merged 8 commits into from
Feb 7, 2024

Conversation

subodh1810
Copy link
Contributor

Issue : #34918

@subodh1810 subodh1810 self-assigned this Feb 7, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 8:01pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Feb 7, 2024
xiaohansong
xiaohansong approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@xiaohansong xiaohansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@subodh1810
Copy link
Contributor Author

subodh1810 commented Feb 7, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/7819403442
❌ Publish Java CDK version=0.16.5 failed!

akashkulk
akashkulk previously requested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@akashkulk akashkulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in slack, can you bump Postgres version and bump the cdk it is using too?

@subodh1810 subodh1810 requested a review from a team as a code owner February 7, 2024 19:18
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/postgres labels Feb 7, 2024
@subodh1810 subodh1810 requested a review from akashkulk February 7, 2024 19:20
@subodh1810
Copy link
Contributor Author

Postgres tests pass with the cdk changes
Screenshot 2024-02-08 at 1 15 48 AM

@subodh1810
Copy link
Contributor Author

subodh1810 commented Feb 7, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/7820326940
✅ Successfully published Java CDK version=0.16.5!

@airbytehq airbytehq deleted a comment from github-actions bot Feb 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 69.34% 🍏

@postamar postamar dismissed akashkulk’s stale review February 7, 2024 20:28

Akash is out for lunch and his concerns have been addressed.

@subodh1810 subodh1810 merged commit 6e4ed76 into master Feb 7, 2024
25 checks passed
@subodh1810 subodh1810 deleted the fix-state-stats-count-java-cdk branch February 7, 2024 20:31
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@subodh1810 @xiaohansong
db-sources-java-cdk: fix logic to calculate the state stats count in …
bf0b2c7 
…db sources iterator (#34948)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@subodh1810 @jatinyadav-cc
db-sources-java-cdk: fix logic to calculate the state stats count in …
ec1c63d 
…db sources iterator (airbytehq#34948)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@subodh1810 @jatinyadav-cc
db-sources-java-cdk: fix logic to calculate the state stats count in …
5f3a99d 
…db sources iterator (airbytehq#34948)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@subodh1810 @jatinyadav-cc
db-sources-java-cdk: fix logic to calculate the state stats count in …
280b54c 
…db sources iterator (airbytehq#34948)
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@subodh1810 @xiaohansong
db-sources-java-cdk: fix logic to calculate the state stats count in …
42c7388 
…db sources iterator (#34948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaohansong xiaohansong xiaohansong approved these changes

@akashkulk akashkulk Awaiting requested review from akashkulk

Assignees

@subodh1810 subodh1810

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@subodh1810 @xiaohansong @akashkulk @octavia-squidington-iii