Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-postgres/mysql: fix wrong tags in metadata #34980

Merged
merged 1 commit into from
Feb 7, 2024
Merged

source-postgres/mysql: fix wrong tags in metadata #34980

merged 1 commit into from
Feb 7, 2024

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Feb 7, 2024 •
edited
Loading

source-mysql and source-postgres had language:python tags...

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 9:59pm

@alafanechere Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@alafanechere alafanechere marked this pull request as ready for review February 7, 2024 22:01
@alafanechere alafanechere requested a review from a team as a code owner February 7, 2024 22:01
@alafanechere alafanechere enabled auto-merge (squash) February 7, 2024 22:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 69.34% 🍏

@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="fixing a typo in metadata.yaml file"

@octavia-approvington
Copy link
Contributor

This is really good
simply the best

@octavia-approvington octavia-approvington merged commit 9dc5bf3 into master Feb 7, 2024
30 of 37 checks passed
@octavia-approvington octavia-approvington deleted the augustin/02-07-source-postgres/mysql_fix_wrong_tags_in_metadata branch February 7, 2024 22:18
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@alafanechere @xiaohansong
source-postgres/mysql: fix wrong tags in metadata (#34980)
4580069
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@alafanechere @jatinyadav-cc
source-postgres/mysql: fix wrong tags in metadata (airbytehq#34980)
4cfce30
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@alafanechere @jatinyadav-cc
source-postgres/mysql: fix wrong tags in metadata (airbytehq#34980)
ef79d05
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@alafanechere @jatinyadav-cc
source-postgres/mysql: fix wrong tags in metadata (airbytehq#34980)
3732d0f
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@alafanechere @xiaohansong
source-postgres/mysql: fix wrong tags in metadata (#34980)
1aed461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephane-airbyte stephane-airbyte stephane-airbyte approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

@evantahler evantahler Awaiting requested review from evantahler

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/mysql connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alafanechere @octavia-approvington @stephane-airbyte @octavia-squidington-iii