-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradle: de-gradleize unpopular destinations #35195
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
b3c85b1
to
a681209
Compare
Will these connector be still publishing in case we need to release one? |
These connectors are slated to be removed from the registry entirely. Publish-ability doesn't really matter any more. |
These destinations are underused and undermaintained. Let's remove them from the gradle project structure. Someone else can pull the trigger for good.
How this works: in https://github.com/airbytehq/airbyte/blob/master/settings.gradle#L185 we loop over all dirs in
airbyte-integrations/connectors/
and look for abuild.gradle
file; if it's found then the dir is registered as a gradle project, otherwise it's ignored by gradle. This is useful because IntelliJ bases itself on the gradle "model" to index all of the project structure and source files.De-indexing this code will be immediately useful to me in my CDK work.