Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: de-gradleize unpopular destinations #35195

Closed
wants to merge 2 commits into from

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Feb 13, 2024

These destinations are underused and undermaintained. Let's remove them from the gradle project structure. Someone else can pull the trigger for good.

How this works: in https://github.com/airbytehq/airbyte/blob/master/settings.gradle#L185 we loop over all dirs in airbyte-integrations/connectors/ and look for a build.gradle file; if it's found then the dir is registered as a gradle project, otherwise it's ignored by gradle. This is useful because IntelliJ bases itself on the gradle "model" to index all of the project structure and source files.

De-indexing this code will be immediately useful to me in my CDK work.

@postamar postamar requested a review from a team as a code owner February 13, 2024 01:04
Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 2:08pm

Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@postamar postamar force-pushed the postamar/degradleize-unpopular-destinations branch from b3c85b1 to a681209 Compare February 14, 2024 14:07
@rodireich
Copy link
Contributor

Will these connector be still publishing in case we need to release one?

@evantahler
Copy link
Contributor

These connectors are slated to be removed from the registry entirely. Publish-ability doesn't really matter any more.

@postamar
Copy link
Contributor Author

postamar commented Feb 19, 2024

Closed in favour of #35423 and #35359

@postamar postamar closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment