Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove destination-kvdb again, again #35459

Closed
wants to merge 2 commits into from

Conversation

evantahler
Copy link
Contributor

No description provided.

@evantahler evantahler marked this pull request as ready for review February 20, 2024 21:43
Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 7:25pm

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment next to the archived supportLevel field in metadata with a link to this PR if we ever want to revert the removal?
I noticed the main.py is still there, is there a good reason to keep it?

@evantahler evantahler force-pushed the evan/remove-kvdb-again-again branch from 4b10791 to 68db01a Compare February 21, 2024 19:17
@evantahler
Copy link
Contributor Author

Can you add a comment next to the archived supportLevel field in metadata with a link to this PR if we ever want to revert the removal?

We won't ever want to revert archived connectors. They don't work right or build properly. The archive is meant to only remain as an inspiration for someone to start a new connector from scratch, and to keep our old code source-available.

I noticed the main.py is still there, is there a good reason to keep it?

Oops! Merge conflict or something. Just the metadata.yaml and icon should remain

@erohmensing erohmensing removed their request for review February 23, 2024 20:59
@evantahler evantahler closed this Feb 28, 2024
@evantahler evantahler deleted the evan/remove-kvdb-again-again branch February 28, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants