-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove destination-kvdb again, again #35459
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment next to the archived
supportLevel field in metadata with a link to this PR if we ever want to revert the removal?
I noticed the main.py
is still there, is there a good reason to keep it?
4b10791
to
68db01a
Compare
We won't ever want to revert archived connectors. They don't work right or build properly. The archive is meant to only remain as an inspiration for someone to start a new connector from scratch, and to keep our old code source-available.
Oops! Merge conflict or something. Just the metadata.yaml and icon should remain |
No description provided.