Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Attempt to fix transient nightly build errors: Remove poetry … #36206

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Revert "Attempt to fix transient nightly build errors: Remove poetry … #36206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41a7d42
Revert "Attempt to fix transient nightly build errors: Remove poetry …
maxi297 Mar 15, 2024
65b7539
Up version
maxi297 Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ E.G.: running Poe tasks on the modified internal packages of the current branch:

| Version | PR | Description |
| ------- | ---------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------- |
| 4.5.4 | [#36206](https://github.com/airbytehq/airbyte/pull/36206) | Revert poetry cache removal during nightly builds |
| 4.5.3 | [#34586](https://github.com/airbytehq/airbyte/pull/34586) | Extract connector changelog modification logic into its own class |
| 4.5.2 | [#35802](https://github.com/airbytehq/airbyte/pull/35802) | Fix bug with connectors bump_version command |
| 4.5.1 | [#35786](https://github.com/airbytehq/airbyte/pull/35786) | Declare `live_tests` as an internal poetry package. |
Expand Down
6 changes: 2 additions & 4 deletions airbyte-ci/connectors/pipelines/pipelines/dagger/actions/python/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from dagger import Container, Directory
from pipelines import hacks
from pipelines.airbyte_ci.connectors.context import ConnectorContext, PipelineContext
from pipelines.dagger.containers.python import with_pip_cache, with_python_base, with_testing_dependencies
from pipelines.dagger.containers.python import with_pip_cache, with_poetry_cache, with_python_base, with_testing_dependencies
from pipelines.helpers.utils import check_path_in_workdir, get_file_contents


Expand Down Expand Up @@ -211,9 +211,7 @@ async def with_installed_python_package(
has_pyproject_toml = await check_path_in_workdir(container, "pyproject.toml")

if has_pyproject_toml:
# This is a temporary change in order to scope an issue. There should be following action items once we have more information.
# maxi297 has an action item on his calendar for 2024-03-21 to review this
# container = with_poetry_cache(container, context.dagger_client)
container = with_poetry_cache(container, context.dagger_client)
container = _install_python_dependencies_from_poetry(container, additional_dependency_groups, install_root_package)
elif has_setup_py:
container = with_pip_cache(container, context.dagger_client)
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "pipelines"
version = "4.5.3"
version = "4.5.4"
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
authors = ["Airbyte <contact@airbyte.io>"]

Expand Down
Loading