🐛[source-confluence] 'expand' request parameter converted to comma separated string #36339
+1,089
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
marcosmarxm
changed the title
|
I'm going to run integration tests and validate the change @cjkindel thanks for the contribution. |
talweissler
approved these changes
Mar 21, 2024
|
It appears I need someone w/ permissions to rebase/run tests/merge or else I will be stuck in a rebase loop |
|
@cjkindel I need to create a duplicated non-forked branch to run tests properly to your contribution. I'm going to this week, sorry the delay! |
marcosmarxm
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Waiting CI to merge the contribution @cjkindel thanks for this!
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
…parated string (airbytehq#36339) Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atlassian APIs like Confluence support an
expandrequest parameter that expands the response to include the requested fields. The documentation for this parameter states that it must be a comma separated string. The Page and Blogpostexpandparameters were not strings. I updated all 3expandparameters (including the functional but out-of-spec Space's) to meet the specification of comma separated string.Atlassian Documentation: https://developer.atlassian.com/server/confluence/expansions-in-the-rest-api/
Related Issue: #33347