Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Sendgrid: unpin CDK version #36455

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Source Sendgrid: unpin CDK version #36455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
923e2df
unpin CDK version
ChristoGrab Mar 25, 2024
c5b64f3
changelog
ChristoGrab Mar 25, 2024
81445e3
switch to minor version bump
ChristoGrab Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-sendgrid/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ acceptance_tests:
status: "failed"
discovery:
tests:
- config_path: "secrets/old_config.json"
- config_path: "secrets/config.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that there seemed to be a very conscious change to switch from config.json to old_config.json in this PR back in 2022. The only difference in the files I pulled from GCS is start_time changing from "2019-05-20T13:43:57.000Z" to "2019-05-20T13:43:57Z".

But since it looks like CI tests are passing just fine now, I'm good with the change and thanks for updating. Just adding context in case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks for double-checking to verify!

backward_compatibility_tests_config:
disable_for_version: "0.3.0"
basic_read:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-sendgrid/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: fbb5fbe2-16ad-4cf4-af7d-ff9d9c316c87
dockerImageTag: 0.4.3
dockerImageTag: 0.5.0
dockerRepository: airbyte/source-sendgrid
documentationUrl: https://docs.airbyte.com/integrations/sources/sendgrid
githubIssueLabel: source-sendgrid
Expand Down
Loading
Loading