convert missing s3-destinations tests #36570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Mar 27, 2024
stephane-airbyte
force-pushed
the
stephane/03-24-convert_java_cdk_dependencies_submodule_to_kotlin
branch
from
187bfba to
d7e7e2e
Compare
stephane-airbyte
force-pushed
the
stephane/03-27-convert_missing_s3-destinations_tests
branch
from
33cbce5 to
11bc6a0
Compare
Merged
stephane-airbyte
requested review from
gisripa and
jdpgrailsdev
and removed request for
a team
|
/publish-java-cdk |
gisripa
reviewed
Mar 27, 2024
| @JvmField val pathFormat: String | ||
| val s3CredentialConfig: S3CredentialConfig | ||
| @JvmField val pathFormat: String? | ||
| val s3CredentialConfig: S3CredentialConfig? | ||
| @JvmField val formatConfig: S3FormatConfig? |
There was a problem hiding this comment.
Want to convert these to property ? since they are accessed using getters. Or as a subsequent PR.
gisripa
approved these changes
Mar 27, 2024
Base automatically changed from
stephane/03-24-convert_java_cdk_dependencies_submodule_to_kotlin
to
master
March 27, 2024 21:07
stephane-airbyte
force-pushed
the
stephane/03-27-convert_missing_s3-destinations_tests
branch
from
11bc6a0 to
5209ba2
Compare
Merge activity
|
stephane-airbyte
deleted the
stephane/03-27-convert_missing_s3-destinations_tests
branch
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.