CDK module changes for destination #36588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
commented
Mar 28, 2024
...res/kotlin/io/airbyte/cdk/integrations/standardtest/destination/DestinationAcceptanceTest.kt
Outdated
Show resolved
Hide resolved
gisripa
commented
Mar 28, 2024
...estFixtures/kotlin/io/airbyte/cdk/integrations/standardtest/destination/TestingNamespaces.kt
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/cdkk-destination-fixes
branch
3 times, most recently
from
c44486f to
5610dfe
Compare
gisripa
commented
Mar 28, 2024
| fun uploadManifest(bucketName: String, manifestFilePath: String, manifestContents: String) { | ||
| s3Client.putObject(s3Config.bucketName, manifestFilePath, manifestContents) | ||
| } | ||
|
|
There was a problem hiding this comment.
This method got nuked out of orbit.. diff is just resurrection.
gisripa
force-pushed
the
gireesh/cdkk-destination-fixes
branch
2 times, most recently
from
183757d to
d396108
Compare
gisripa
commented
Mar 28, 2024
airbyte-cdk/java/airbyte-cdk/dependencies/src/main/kotlin/io/airbyte/commons/io/IOs.kt
Show resolved
Hide resolved
gisripa
commented
Mar 28, 2024
...-cdk/java/airbyte-cdk/dependencies/src/main/kotlin/io/airbyte/commons/jackson/MoreMappers.kt
Show resolved
Hide resolved
gisripa
commented
Mar 28, 2024
| @@ -44,9 +44,10 @@ object Jsons { | |||
| private val YAML_OBJECT_MAPPER: ObjectMapper = MoreMappers.initYamlMapper(YAMLFactory()) | |||
There was a problem hiding this comment.
[Re: line 29]
This whole class should be just companion object.
See this comment inline on Graphite.
This whole class should be just companion object.
See this comment inline on Graphite.
gisripa
force-pushed
the
gireesh/cdkk-destination-fixes
branch
5 times, most recently
from
224bcb8 to
7466653
Compare
...a/airbyte-cdk/dependencies/src/main/kotlin/io/airbyte/validation/json/JsonSchemaValidator.kt
Outdated
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/cdkk-destination-fixes
branch
from
7466653 to
08d1dcd
Compare
This was referenced Mar 28, 2024
gisripa
force-pushed
the
gireesh/cdkk-destination-fixes
branch
2 times, most recently
from
9370fc8 to
cd4a7c2
Compare
airbyte-cdk/java/airbyte-cdk/dependencies/src/main/kotlin/io/airbyte/commons/string/Strings.kt
Outdated
Show resolved
Hide resolved
| @@ -14,18 +14,8 @@ package io.airbyte.integrations.base.destination.typing_deduping | |||
| * Useful if a destination warehouse handles columns ignoring case, but preserves case in the table | |||
| * schema. | |||
| */ | |||
| class ColumnId(name: String, originalName: String, canonicalName: String) { | |||
| data class ColumnId(val name: String, val originalName: String, val canonicalName: String) { | |||
| ) { | ||
| val rawTableExists: Boolean | ||
| val hasUnprocessedRecords: Boolean | ||
| data class InitialRawTableStatus( |
| @@ -58,7 +58,7 @@ abstract class BaseSqlGeneratorIntegrationTest<DestinationState : MinimumDestina | |||
| protected var cdcIncrementalAppendStream: StreamConfig? = null | |||
|
|
|||
| protected var generator: SqlGenerator? = null | |||
| protected abstract var destinationHandler: DestinationHandler<DestinationState> | |||
| protected abstract val destinationHandler: DestinationHandler<DestinationState> | |||
There was a problem hiding this comment.
not sure why it was defined as a var... Much better as a val. How did you find it?
There was a problem hiding this comment.
making var generated abstract setDestinationHandler method which was never intended to be, just getDestinationHandler
...es/kotlin/io/airbyte/integrations/base/destination/typing_deduping/BaseTypingDedupingTest.kt
Outdated
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/cdkk-destination-fixes
branch
from
cd4a7c2 to
f302124
Compare
stephane-airbyte
approved these changes
Mar 29, 2024
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
### TL;DR Updated JDBC and S3 destination to compile destination-redshift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated JDBC and S3 destination configurations.