Remove the custom implementation of buffered input stream reader #36673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jbfbell
changed the title
gisripa
reviewed
Mar 29, 2024
.../java/airbyte-cdk/core/src/main/kotlin/io/airbyte/cdk/integrations/base/IntegrationRunner.kt
Outdated
Show resolved
Hide resolved
gisripa
reviewed
Mar 29, 2024
.../java/airbyte-cdk/core/src/main/kotlin/io/airbyte/cdk/integrations/base/IntegrationRunner.kt
Show resolved
Hide resolved
jbfbell
force-pushed
the
jbfbell/use_standard_stream_reader
branch
3 times, most recently
from
3e6985a to
cbd5205
Compare
evantahler
approved these changes
Mar 29, 2024
gisripa
approved these changes
Mar 29, 2024
| baos.write(b.toInt()) | ||
| lastWasNewLine = false | ||
| emptyLines++ | ||
| // We've occasionally seen this loop not exit |
There was a problem hiding this comment.
we're not adding any loop, so I don't think we're making the problem worse. And once every 1k lines should not be a problem. If it is, it's a problem on the side that's generating those empty lines IMO
stephane-airbyte
approved these changes
Mar 29, 2024
jbfbell
force-pushed
the
jbfbell/use_standard_stream_reader
branch
from
cbd5205 to
624ccae
Compare
nurikk
pushed a commit
to nurikk/airbyte
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes our custom message reader and uses a standard one. It also will log every 1000 empty lines until a max of 10000 is reached and report the number of empty lines at the end.