Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector-builder: return full url-encoded URL instead of separating parameters #36680

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Mar 29, 2024

Return the full URL with request param encoded instead of separating them in a separate field.

This is the first PR for https://github.com/airbytehq/airbyte-internal-issues/issues/2437

There will be a follow up PR in the platform

@girarda girarda requested a review from a team as a code owner March 29, 2024 01:00
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 29, 2024 1:18am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 29, 2024
@girarda girarda requested a review from lmossman March 29, 2024 01:01
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@girarda girarda merged commit b27ddfe into master Mar 29, 2024
28 checks passed
@girarda girarda deleted the alex/send_fully_encoded_url branch March 29, 2024 01:49
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants