Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

low-code: Replace use of parent_key with partition_field in per-partiton state #36720

Closed
wants to merge 4 commits into from

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Apr 1, 2024

What

Fix states that were poorly migrated by #36294
This is a follow up to this bug fix #36719

How

If the input state is per-partitioned, but has partitions with keys == parent_key instead of the partition_field,
run a migration that renames the field from parent_key -> partition_field

Example input state:

    {
      "partition": {"id": "13506132"},
      "cursor": {"last_changed": "2022-12-27T08:34:39+00:00"}
    }

Example output state:

    {
      "partition": {"parent_id": "13506132"},
      "cursor": {"last_changed": "2022-12-27T08:34:39+00:00"}
    }

Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 2:13pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 1, 2024
@girarda girarda marked this pull request as ready for review April 1, 2024 14:13
@girarda girarda requested a review from a team as a code owner April 1, 2024 14:13
@girarda girarda requested a review from lazebnyi April 1, 2024 14:13
Base automatically changed from lazebnyi/low_code_legacy_state_parent_key_to_partition_field to master April 1, 2024 15:08
@girarda girarda closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants