Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Pivotal-Tracker: Migrate Python CDK to Low-code CDK #36953

Merged
merged 39 commits into from
May 13, 2024
Merged

✨Source Pivotal-Tracker: Migrate Python CDK to Low-code CDK #36953

merged 39 commits into from
May 13, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Migrating Source Pivotal Tracker to Low-Code CDK
Closes airbytehq/airbyte-internal-issues#7010

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance
  • Full passed state:

image

🚨 User Impact 🚨

  • Migration to low-code

btkcodedev and others added 15 commits March 27, 2024 00:36
@btkcodedev
feat: Migrate to low code CDK
a27e5ca
@btkcodedev
Merge branch 'master' into feat/pivotalTrackerLowCode
faff642
@btkcodedev
Retrieve icon, update docs
d285d8e
@btkcodedev
Merge branch 'feat/pivotalTrackerLowCode' of https://github.com/btkco…
aacd66b 
…dedev/airbyte into feat/pivotalTrackerLowCode
@btkcodedev
update version, delete spec.yaml
2db656a
@btkcodedev
feat: custom paginator
0bcf6ab
@girarda
Merge branch 'master' into feat/pivotalTrackerLowCode
b1ce1d4
@girarda
Update airbyte-integrations/connectors/source-pivotal-tracker/metadat…
d10ada5 
…a.yaml
@btkcodedev
Add poetrylock and migrations.md
65c1af7
@btkcodedev
Merge branch 'feat/pivotalTrackerLowCode' of https://github.com/btkco…
f18532b 
…dedev/airbyte into feat/pivotalTrackerLowCode
@btkcodedev
Merge branch 'master' into feat/pivotalTrackerLowCode
3416a17
@btkcodedev
Merge branch 'master' into feat/pivotalTrackerLowCode
63b2bf7
@btkcodedev
Move schema inline, update version, update poetry lock
0341894
@btkcodedev
Merge remote-tracking branch 'fork/feat/pivotalTrackerLowCode' into b…
23aa645 
…tkcodedev/pivotalTrackerLowCode
@btkcodedev
chore: format
5c24baf
@btkcodedev btkcodedev added the low-code-migration This connector has been migrated to the low-code CDK label Apr 10, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 9:23am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 10, 2024
@btkcodedev btkcodedev mentioned this pull request Apr 10, 2024
Closed
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 10, 2024 06:59
@btkcodedev
Copy link
Collaborator Author

Inline Schema ✅
Poetry lock file ✅
No Breaking change ✅
Docs updated ✅

airbyte-ci test All pass state:
Results:
image

@btkcodedev
Copy link
Collaborator Author

Marking PR as ready to merge

@lazebnyi lazebnyi self-requested a review April 10, 2024 13:44
askarpets
askarpets suggested changes Apr 15, 2024
View reviewed changes
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/components.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-pivotal-tracker/source_pivotal_tracker/manifest.yaml Outdated Show resolved Hide resolved
@btkcodedev
Copy link
Collaborator Author

Changes done ✅
CI - Passing

@btkcodedev btkcodedev requested a review from askarpets April 19, 2024 15:58
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Apr 22, 2024 •
edited
Loading

@askarpets All comments resolved, please continue the merge process 🙇

@btkcodedev
Copy link
Collaborator Author

Tests fixed ✅

@btkcodedev
Copy link
Collaborator Author

Comments resolved, Please continue merging process

@btkcodedev btkcodedev requested a review from askarpets May 2, 2024 11:53
@btkcodedev btkcodedev requested a review from lazebnyi May 9, 2024 07:07
@askarpets askarpets requested a review from girarda May 9, 2024 11:55
@lazebnyi lazebnyi merged commit debca39 into master May 13, 2024
35 checks passed
@lazebnyi lazebnyi deleted the btkcodedev/pivotalTrackerLowCode branch May 13, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@askarpets askarpets askarpets approved these changes

@girarda girarda Awaiting requested review from girarda

Assignees

@askarpets askarpets

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pivotal-tracker low-code-migration This connector has been migrated to the low-code CDK team/connectors-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@btkcodedev @askarpets @lazebnyi @octavia-squidington-iii @girarda