Source Quick Books: hide in cloud #37007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 97bf384
- Looked at
14lines of code in1files - Took 1 minute and 3 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. airbyte-integrations/connectors/source-quickbooks/metadata.yaml:24:
- Assessed confidence :
50% - Comment:
This change disables the QuickBooks connector in the cloud. Please ensure that there are no other parts of the system that rely on this connector being enabled in the cloud, as this change could potentially break those functionalities. - Reasoning:
The change in the PR is to disable the QuickBooks connector in the cloud. This is done by changing the 'enabled' field under 'cloud' in 'registries' from 'true' to 'false'. This seems to be a straightforward change and there doesn't appear to be any logical, performance, or security bugs. However, it's important to ensure that this change doesn't affect other parts of the system that might be relying on this connector being enabled in the cloud.
Workflow ID: wflow_3KIQSC3V0f2mUwcQ
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
|
/approve-and-merge reason="PR hide connector in cloud" |
|
This is really good |
octavia-approvington
approved these changes
Apr 11, 2024
octavia-approvington
deleted the
lazebnyi/disable-source-quick-books-for-cloud
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connector have hidden in cloud as its cannot be configured - https://airbyte-globallogic.slack.com/archives/C02U9R3AF37/p1712858803196519?thread_ts=1706114304.283499&cid=C02U9R3AF37
Summary:
This PR disables the QuickBooks connector in the cloud by modifying the
enabledfield in themetadata.yamlfile of thesource-quickbooksconnector.Key points:
metadata.yamlfile ofsource-quickbooksconnectorenabledfield undercloudinregistrieschanged fromtruetofalseGenerated with ❤️ by ellipsis.dev