🐛 Fix Stripe Schema. #3744
Merged
🐛 Fix Stripe Schema. #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test connector=source-stripe
|
sherifnada
approved these changes
May 30, 2021
|
/test connector=source-stripe
|
|
/publish connector=connectors/source-stripe
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
One of the schema's has a wrong type and should be string instead of integer. I discovered this while trying to debug a user's error.
This was erroring out E2E locally for me, and works after this change (for the entire catalog).
Second change is a cursor field that is missing from the schema. This took me a while to debug. Since the resource contains an object that has a field of the same name.
The two most recent syncs are after I corrected this error.
How
Change the type.
Pre-merge Checklist
Recommended reading order