✨Source Salesforce: Migrating to non-deprecated authenticator #38065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
cmm-airbyte
approved these changes
May 8, 2024
aldogonzalez8
approved these changes
May 8, 2024
octavia-squidington-iii
added
the
area/documentation
maxi297
force-pushed
the
maxi297/migrate-to-non-deprecated-authenticator
branch
from
7aa39da to
f5849aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In other to prepare for RFR breaking changes and to ease the changes for using HttpClient, we are removing the deprecated auth.
How
Migrating to
requests_native_authand removing unnecessary usage in salesforce's code.Review guide
airbyte-integrations/connectors/source-salesforce/source_salesforce/source.py: the migrationairbyte-integrations/connectors/source-salesforce/source_salesforce/streams.py: removing the usage. As those leverageHttpStream._sessionthey should have the authentication set through Session.authUser Impact
None for the customers. For the devs, it should facilitate future migrations
Can this PR be safely reverted and rolled back?