✨ Source Shopify: add resiliency on some transient errors using the HttpClient #38084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
… for the product_images
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…migrate-product-images-variants-to-bulk
…ct-images-variants-to-bulk' into strosek/test-conn-err-retry
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
maxi297
reviewed
May 25, 2024
bazarnov
requested changes
May 27, 2024
airbyte-integrations/connectors/source-shopify/unit_tests/integration/api/authentication.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/unit_tests/integration/api/authentication.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-shopify/unit_tests/integration/api/bulk.py
Outdated
Show resolved
Hide resolved
| }""" | ||
| inner_query = inner_query.replace("%LOWER_BOUNDARY_TOKEN%", lower_boundary.isoformat()) | ||
| inner_query = inner_query.replace("%UPPER_BOUNDARY_TOKEN%", upper_boundary.isoformat()) | ||
| outer_query = outer_query.replace("%INNER_QUERY_TOKEN%", inner_query) |
There was a problem hiding this comment.
We can also leverage the stream_slices() method, to produce 1 slice, or multiple slices, instead of directly injecting the date-time str.
There was a problem hiding this comment.
It feels like we like this isn't reducing the readability of the test and that we should not rely on the source code to create our expectations for the slices that will be produced
airbyte-integrations/connectors/source-shopify/unit_tests/integration/api/bulk.py
Outdated
Show resolved
Hide resolved
maxi297
changed the title
bazarnov
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The scope of this PR has changed. I has been used to integrate the HttpClient in order for us to retry on connection errors.
Initial part:
Add tests for reading records from a GraphQL bulk in Shopify. Those were added as part of https://github.com/airbytehq/airbyte-internal-issues/issues/7084
Added part:
How
Initial part
Created an integration tests file for testing the entrypoint
read()function. A couple tests were added, one with a successful mock and one with an ConnectionError raised when the mocker tries to build a response.Review guide
The small changes mentioned above have all been reviewed in their own PR. Hence, there should be nothing to review in this one
User Impact
Can this PR be safely reverted and rolled back?