-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[source-s3] Bump the Python CDK to include the CSV field length fix #38090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
blarghmatey
had a problem deploying
to
community-ci-auto
May 9, 2024 18:15 — with
GitHub Actions
Error
blarghmatey
had a problem deploying
to
community-ci-auto
May 9, 2024 18:15 — with
GitHub Actions
Error
blarghmatey
force-pushed
the
source_s3_csv_field_size
branch
from
May 9, 2024 18:17
076c88f
to
38c2bda
Compare
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
May 9, 2024
blarghmatey
force-pushed
the
source_s3_csv_field_size
branch
from
May 9, 2024 18:19
38c2bda
to
46d071f
Compare
blarghmatey
had a problem deploying
to
community-ci-auto
May 9, 2024 18:19 — with
GitHub Actions
Error
blarghmatey
had a problem deploying
to
community-ci-auto
May 9, 2024 18:19 — with
GitHub Actions
Error
blarghmatey
force-pushed
the
source_s3_csv_field_size
branch
from
May 9, 2024 18:20
46d071f
to
24c5bc1
Compare
@marcosmarxm Here's the PR to bump the CDK for S3 to include the CSV field length fix. Thanks! |
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 18:21 — with
GitHub Actions
Inactive
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 18:21 — with
GitHub Actions
Inactive
blarghmatey
force-pushed
the
source_s3_csv_field_size
branch
from
May 9, 2024 19:33
24c5bc1
to
1f00b9d
Compare
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 19:34 — with
GitHub Actions
Inactive
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 19:34 — with
GitHub Actions
Inactive
blarghmatey
force-pushed
the
source_s3_csv_field_size
branch
from
May 9, 2024 20:14
1f00b9d
to
0ce73c4
Compare
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 20:15 — with
GitHub Actions
Inactive
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 20:15 — with
GitHub Actions
Inactive
blarghmatey
force-pushed
the
source_s3_csv_field_size
branch
from
May 9, 2024 20:49
0ce73c4
to
f3aa1d5
Compare
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 20:49 — with
GitHub Actions
Inactive
blarghmatey
temporarily deployed
to
community-ci-auto
May 9, 2024 20:49 — with
GitHub Actions
Inactive
marcosmarxm
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @blarghmatey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/s3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This fixes the bug in the S3 source connector with CSV files having a field length exceeding 128k that was addressed in the CDK as part of #36320
How
Bump the Python CDK version to include the relevant fix
Review guide
User Impact
Users will be able to ingest CSV files that have fields with larger data values
Can this PR be safely reverted and rolled back?