Add support for binary _id field in source-mongodb #38103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
rodireich
commented
May 10, 2024
| this.converter = converter; | ||
| } | ||
|
|
||
| public Object convert(final String t) { |
There was a problem hiding this comment.
Note: dead code removed. not used anywhere other than a test
akashkulk
approved these changes
May 10, 2024
rodireich
deleted the
36820-source-mongodb-add-support-for-uuid-as-_id-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Source-mongodb can't read collections whose id is a binary. Most commonly used for UUIDs.
This change adds the mongodb Binary type as an acceptable id.
How
ID of binary type will now be parsed correctly and will be saved in state for checkpointing.
Specifically for UUID binary the state will save a human readable value (e.g
"D1AF5D9B-377E-4FB7-AE4E-63E875D16C6F") while for all other binaries a base64 encoded value will be saved in state. (e.genp6enp6enp6eg==).There is no change in how we convert columns to airbyte records.
Review guide
IdType.javaMongoDbInitialLoadRecordIterator.javaMongoDbStateManager.javaUser Impact
Collections whose
_idtype is binary were previously blocked and can be added now.All previously allowed collection read should continue to by synced without interruption.
Can this PR be safely reverted and rolled back?