Destination BigQuery: Nuking old remnants #38111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
changed the title
gisripa
commented
May 10, 2024
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class BigQueryTableWriter implements DestinationWriter { | ||
| public record BigQueryTableWriter(TableDataWriteChannel writeChannel) { |
There was a problem hiding this comment.
Deleting remnants of DestinationWriter from pre-async days
gisripa
commented
May 10, 2024
.../main/java/io/airbyte/integrations/destination/bigquery/uploader/BigQueryDirectUploader.java
Outdated
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/05-09-bigquery-delete-unused
branch
from
a107209 to
85a9f2d
Compare
edgao
reviewed
May 10, 2024
...c/main/java/io/airbyte/integrations/destination/bigquery/BigQueryStagingConsumerFactory.java
Outdated
Show resolved
Hide resolved
| final HashMap<String, Object> destinationV2record = new HashMap<>(); | ||
| destinationV2record.put(JavaBaseConstants.COLUMN_NAME_AB_RAW_ID, UUID.randomUUID().toString()); | ||
| destinationV2record.put(JavaBaseConstants.COLUMN_NAME_AB_EXTRACTED_AT, getEmittedAtField(recordMessage.getRecord())); | ||
| destinationV2record.put(JavaBaseConstants.COLUMN_NAME_AB_LOADED_AT, null); |
There was a problem hiding this comment.
is there even a point to sending an explicit null for loaded_at? (I'm guessing this is copied from existing code, just seems weird)
... or, if we're immediately serializing it, why not just build a JsonNode directly?
|
|
||
| public void upload(final PartialAirbyteMessage airbyteMessage) { | ||
| try { | ||
| writer.write(recordFormatter.formatRecord(airbyteMessage)); |
There was a problem hiding this comment.
are we intentionally not batching multiple records together?
.../main/java/io/airbyte/integrations/destination/bigquery/uploader/BigQueryDirectUploader.java
Outdated
Show resolved
Hide resolved
.../main/java/io/airbyte/integrations/destination/bigquery/uploader/BigQueryDirectUploader.java
Outdated
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/05-09-bigquery-delete-unused
branch
2 times, most recently
from
84b5358 to
ec1c3ff
Compare
edgao
approved these changes
May 10, 2024
gisripa
force-pushed
the
gireesh/05-09-bigquery-delete-unused
branch
from
ec1c3ff to
7c18c66
Compare
gisripa
force-pushed
the
gireesh/05-09-bigquery-delete-unused
branch
from
7c18c66 to
a6c5dc5
Compare
gisripa
force-pushed
the
gireesh/05-09-bigquery-delete-unused
branch
from
a6c5dc5 to
e1b60e0
Compare
octavia-squidington-iii
added
the
area/documentation
gisripa
force-pushed
the
gireesh/05-09-bigquery-delete-unused
branch
from
e1b60e0 to
471efe5
Compare
stephane-airbyte
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removing remnants from old code. There is only CSV support and one implementation for DirectUploader in standard inserts, unified them into a single class removing unused methods for easier refactoring when needed.
No functional changes should happen with this PR.
Review guide
User Impact
Can this PR be safely reverted and rolled back?