Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure AirbyteExceptionHandler always terminates #38122

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented May 10, 2024

we have some destinations that are hanging because the exception handler throws an exception that prevents it from terminating the connector. Hopefully that'll let the connector commit seppuku

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 6:32pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 10, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte marked this pull request as ready for review May 10, 2024 18:25
@stephane-airbyte stephane-airbyte requested review from a team as code owners May 10, 2024 18:25
@stephane-airbyte stephane-airbyte force-pushed the stephane/05-10-make_sure_airbyteexceptionhandler_always_terminates branch from 3e71304 to 29554d9 Compare May 10, 2024 18:31
Copy link
Contributor

@gisripa gisripa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stephane-airbyte stephane-airbyte merged commit 44a24ef into master May 10, 2024
33 checks passed
Copy link
Contributor Author

Merge activity

@stephane-airbyte stephane-airbyte deleted the stephane/05-10-make_sure_airbyteexceptionhandler_always_terminates branch May 10, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants