Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Google page speed insights: Make Connector Compatible with Builder #38147

Merged
merged 7 commits into from
May 22, 2024
Merged

✨Source Google page speed insights: Make Connector Compatible with Builder #38147

merged 7 commits into from
May 22, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 12, 2024
@vercel Vercel
Copy link

vercel bot commented May 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:50pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 12, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 12, 2024 06:10
@btkcodedev
Copy link
Collaborator Author

Removed $parameters macro ✅
Embed Spec ✅

GitHub CI Green ✅, Ready to merge
image

@btkcodedev btkcodedev requested a review from girarda May 19, 2024 14:31
girarda
girarda approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@girarda girarda merged commit 0d7bf96 into master May 22, 2024
27 of 30 checks passed
@girarda girarda deleted the btkcodedev/googlePageSpeedInsightsCompatable branch May 22, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-pagespeed-insights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btkcodedev @girarda @octavia-squidington-iii