Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [source-firebolt] update sdk #38190

Merged
merged 11 commits into from
May 14, 2024
Merged

Conversation

marcosmarxm
Copy link
Member

What

Finish PR for #36349

How

Fix tests and stuff.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

@marcosmarxm marcosmarxm requested a review from rwask May 14, 2024 16:51
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 5:08pm

Copy link
Contributor

@rwask rwask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosmarxm marcosmarxm merged commit 04a75f9 into master May 14, 2024
32 of 34 checks passed
@marcosmarxm marcosmarxm deleted the marcos/source-firebolt-sdk-update branch May 14, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/firebolt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants