-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Salesforce: Use new delete method of HttpMocker for test_bulk_stream #38205
Source Salesforce: Use new delete method of HttpMocker for test_bulk_stream #38205
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bcef3f6
to
99e82c8
Compare
99e82c8
to
7144fa4
Compare
7144fa4
to
62b12fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, however, I'd like to ask @maxi297 to say the same, before we merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small nit
62b12fe
to
1ce7cae
Compare
1ce7cae
to
c5f29b6
Compare
What
Resolving Mock server tests: Support mocking
delete
How
Use the new delete method of HttpMocker for test_bulk_stream
User Impact
e.g.
instead of
Now we use:
Can this PR be safely reverted and rolled back?