Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airbyte CDK: remove unreleased version #38237

Merged
merged 1 commit into from
May 16, 2024

Conversation

aldogonzalez8
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 commented May 15, 2024

What

I'm amending my misunderstanding of the release process. For CDK, there is a GHA that generates new versions, so there is no need to bump up manually.

How

I just removed the release version text 88.3 The change was released in 88.4.

User Impact

There is no impact, the 88.3 version was not released

image

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) May 15, 2024 9:59pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 15, 2024
@aldogonzalez8 aldogonzalez8 marked this pull request as ready for review May 15, 2024 21:59
@aldogonzalez8 aldogonzalez8 requested a review from a team as a code owner May 15, 2024 21:59
@aldogonzalez8 aldogonzalez8 self-assigned this May 15, 2024
@aldogonzalez8 aldogonzalez8 changed the title Airbyte CDK: remove unrelease version Airbyte CDK: remove unreleased version May 15, 2024
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You can merge, no need to release!

@aldogonzalez8 aldogonzalez8 merged commit b82e1ed into master May 16, 2024
34 checks passed
@aldogonzalez8 aldogonzalez8 deleted the aldogonzalez8/remove_unreleased_cdk_version branch May 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants