Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(docs): Fix font weight 500 omission being a style rule #38295

Merged

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented May 16, 2024

Problem

  1. We have new designs that need font weight 500
  2. We did not import that font weight for inter in our docs site
  3. After importing, our navigation titles went from 400 to 500 font weight
  4. This is because our styling was relying on the omission!

Solution

  1. Import font weight 500
  2. Find areas that were using 500 and downgrade them to 400 (because thats the visual equivalent of where we are today)er

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 5:32pm

Copy link
Contributor Author

bnchrch commented May 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bnchrch and the rest of your teammates on Graphite Graphite

Comment on lines 7 to 9
importers:

.:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnchrch do you know why there are so many changes to the lock file in this PR? The other changes look good to me but I wanted to understand why this is changing so much before approving

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. I ran pnpm install 🤷

I can revert that file no problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, when I revert that file, and then run pnpm install, it produces no changes to the lock file.

Not sure why it is different for you but lets go ahead and revert it

@bnchrch bnchrch force-pushed the 05-16-bug_docs_fix_font_weight_500_omission_being_a_style_rule branch from 44c0a37 to e3ec635 Compare May 16, 2024 21:06
@bnchrch bnchrch requested a review from lmossman May 16, 2024 21:07
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnchrch bnchrch force-pushed the 05-16-bug_docs_fix_font_weight_500_omission_being_a_style_rule branch from e3ec635 to a2a5b1a Compare May 22, 2024 17:28
@bnchrch bnchrch merged commit 5237a1f into master May 22, 2024
27 checks passed
@bnchrch bnchrch deleted the 05-16-bug_docs_fix_font_weight_500_omission_being_a_style_rule branch May 22, 2024 19:12
Copy link
Contributor Author

bnchrch commented May 22, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants