airbyte-ci: fix extra steps running when selected commands are provided #38549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
clnoll
requested review from
bnchrch and
alafanechere
and removed request for
a team
alafanechere
approved these changes
May 22, 2024
Comment on lines
+321
to
+323
| # If any `skip_steps` are present, we will run everything except the skipped steps, instead of just `keep_steps`. | ||
| if not run_step_options.keep_steps: | ||
| run_step_options.skip_steps += self._get_step_id_to_skip_according_to_metadata() |
There was a problem hiding this comment.
Thanks for catching this interesting edge case.
We should normally be protected from this issue as the __post__init__ of RunStepOptions raises an error if we both use skip_steps and keeped_steps.
The problem appeared because I my change set skips_steps post instantiation.
Your if introductions looks good and straightforward to me: if the users passed specific step to only run (via keep steps) the test skipping logic is bypassed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue discussed here, where we were running all tests during the version increment check, instead of simply running the version increment check.
I think the logic around
skip_stepsandkeep_stepsis a little hard to follow so would be worth taking another look at some point, but this should fix the problem in the short term.