Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Marketo: update deprecated authenticator #38631

Merged
merged 5 commits into from
May 23, 2024
Merged

Source Marketo: update deprecated authenticator #38631

merged 5 commits into from
May 23, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented May 23, 2024 •
edited
Loading

What

Updates the authenticator for source Marketo to use the requests_native_auth package.

How

  • Pinned connector to CDK version 0.90.0
  • Refactored authenticator to use getter methods
  • Updated a couple failing unit tests

Review Guide

  1. source.py
  2. unit_tests/test_source.py

User Impact

No impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 8:30pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 23, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review May 23, 2024 20:35
@ChristoGrab ChristoGrab requested a review from girarda May 23, 2024 20:41
girarda
girarda approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thank you! 🚢

@ChristoGrab ChristoGrab merged commit 503e397 into master May 23, 2024
34 checks passed
@ChristoGrab ChristoGrab deleted the christo/marketo/auth branch May 23, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/marketo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristoGrab @girarda @octavia-squidington-iii