Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐ New Source: Goldcast #38786

Merged

Conversation

FVidalCarneiro
Copy link
Contributor

@FVidalCarneiro FVidalCarneiro commented May 30, 2024

What

This Pull Request aims in responding to issue (#38785) by proposing a first version of the Goldcast source connector.

How

This PR adds 8 base streams of the Goldcast API:

  • organizations
  • events
  • webinars
  • event_members
  • event_agenda
  • agenda_items
  • discussion_groups
  • tracks

This connector was developed using the low-code development framework.

Schemas of the ingested objects are defined in the schemas/ directory.

Review guide

  1. manifest.yaml
  2. README.md
  3. No particular order after

User Impact

User will have access to 8 streams of a new stream.

Attention: It is worth mentioning that due to field limitations on Goldcast side, only full append stream ingestion modes are supported. This is no cursor field available yet for these API objects.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌ (as soon as it is merged, customers could potentially use it in production)

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 9:06am

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great and I'd be happy to merge this once CI passes. This should then be available promptly once it populates to registry.

I left some suggestions, and I'd love you to act on them if you have time.



# Declarative Source
class SourceGoldcast(YamlDeclarativeSource):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory you can drop this file and just inherit from YamlDeclarativeSource in main.py, but it's okay either way

@@ -0,0 +1,191 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to inline schema in the yaml manifest, but again, can come later. Esp if you're interested in making more sources!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natikgadzhi , Its done as well ! Would you like me to delete these json schemas ? Is it not required ?

@natikgadzhi
Copy link
Contributor

If you can allow me to make changes to this PR, I'm happy to make some changes myself.

@natikgadzhi natikgadzhi enabled auto-merge (squash) July 6, 2024 03:07
Co-authored-by: Natik Gadzhi <natik@respawn.io>
auto-merge was automatically disabled July 8, 2024 06:40

Head branch was pushed to by a user without write access

@natikgadzhi
Copy link
Contributor

@FVidalCarneiro I expec that this will ship today — as long as the tests are green, I'll merge.

@natikgadzhi natikgadzhi enabled auto-merge (squash) July 8, 2024 17:03
@FVidalCarneiro
Copy link
Contributor Author

If you can allow me to make changes to this PR, I'm happy to make some changes myself.

Regarding this point @natikgadzhi , I would gladly share you edit access but I had this problem in another PR where I tried to follow (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) and think it is not possible. Here is the link to the git discussion (#34166 (comment)).

@natikgadzhi natikgadzhi disabled auto-merge July 8, 2024 19:30
@natikgadzhi
Copy link
Contributor

Merging. This should show up on the catalog in an hour or so

@natikgadzhi natikgadzhi merged commit 26f2c01 into airbytehq:master Jul 8, 2024
30 checks passed
@FVidalCarneiro
Copy link
Contributor Author

@natikgadzhi , thank you for your support with this. Happy to have our contributions integrated 😄

@natikgadzhi
Copy link
Contributor

Great work adding a new source! We'll make this very easy in the future, so the next time it doesn't take you months of kicking us to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants