Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source ShortIO: Remove parameters macro, embed spec and schemas #38842

Merged
merged 9 commits into from
Jun 11, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this Jun 1, 2024
Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 5, 2024 10:45am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 1, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team June 1, 2024 16:14
@btkcodedev btkcodedev changed the title ✨Source ShortIO: Make Connector Compatible with Builder ✨Source ShortIO: Emebed spec and schema Jun 1, 2024
@btkcodedev btkcodedev changed the title ✨Source ShortIO: Emebed spec and schema ✨Source ShortIO: Remove parameters macro, embed spec and schemas Jun 1, 2024
@btkcodedev btkcodedev requested a review from girarda June 1, 2024 17:33
@btkcodedev
Copy link
Collaborator Author

CI green
Ready to merge
image

@@ -1,106 +1,432 @@
version: "0.86.0"

definitions:
selector:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've made a change that made it so Builder would ref out blocks like this, so they don't get duplicated in each stream. That's sort of neat. We could always review this later with an automated PR wave, but just curious why this got dereferenced. Did you do that manually, or was that builder?

Copy link
Collaborator Author

@btkcodedev btkcodedev Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natikgadzhi
Not actually, Currently Shortio is not supported by the builder, as it uses different base URLs for different streams
So, Just removed parameters macro, embedded schema and spec for this connector.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we use empty base url and set full url for each stream? ;)

@alafanechere alafanechere merged commit b91d91d into master Jun 11, 2024
38 of 39 checks passed
@alafanechere alafanechere deleted the btkcodedev/shortioCompatible branch June 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation auto-merge connectors/source/shortio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants