-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source ShortIO: Remove parameters macro, embed spec and schemas #38842
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@@ -1,106 +1,432 @@ | |||
version: "0.86.0" | |||
|
|||
definitions: | |||
selector: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've made a change that made it so Builder would ref out blocks like this, so they don't get duplicated in each stream. That's sort of neat. We could always review this later with an automated PR wave, but just curious why this got dereferenced. Did you do that manually, or was that builder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natikgadzhi
Not actually, Currently Shortio is not supported by the builder, as it uses different base URLs for different streams
So, Just removed parameters macro, embedded schema and spec for this connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we use empty base url and set full url for each stream? ;)
What
How
User Impact
Can this PR be safely reverted and rolled back?