Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s3.md #39312

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Update s3.md #39312

merged 3 commits into from
Jun 6, 2024

Conversation

jnr0790
Copy link
Contributor

@jnr0790 jnr0790 commented Jun 6, 2024

What

destination S3 mentions IAM role is done by support, but is a sales assist feature.

How

updating destination S3 doc to point out IAM role is sales assist

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

updating destination S3 to point out IAM role is sales assist
@jnr0790 jnr0790 requested a review from Adorism June 6, 2024 12:28
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 8:07pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 6, 2024
@@ -87,7 +87,7 @@ At this time, object-level permissions alone are not sufficient to successfully
<!-- env:cloud -->

:::note
This authentication method is currently in the testing phase. To enable it for your workspace, please contact our Support Team.
Currently, this feature is available only for the users in a Sales Assist workflow. Please contact your Solutions Engineer if you are interested in using this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we actually point them to the Talk to Sales form? They are not necessarily going to be actively talking with Sales already.
https://airbyte.com/company/talk-to-sales

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nataliekwong let me know if the updated on is better.

add talk to sales form.
Copy link
Contributor

@nataliekwong nataliekwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Audrey Maldonado <audrey.maldonado@gmail.com>
@nataliekwong
Copy link
Contributor

I think you can click "Squash and merge" now, checks are complete. I dont' think I need to approve at this point.

@jnr0790 jnr0790 merged commit b9041c3 into master Jun 6, 2024
26 checks passed
@jnr0790 jnr0790 deleted the jnr0790-destination-S3-doc-update branch June 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants