-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: bust java build cache to fix vulnerabilities #39321
airbyte-ci: bust java build cache to fix vulnerabilities #39321
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
f8b06ac
to
fcd4686
Compare
fcd4686
to
c1fcb96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👊
"yum update -y", | ||
"yum update -y --security", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this update less things (only security) or more things (whatever we updated before AND security)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evantahler It updates less things (only security):
The --security parameter is important. Without it, yum update installs all updates, including bug fixes and enhancements.
(source)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But don't we want all the updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, I think I prefer to know that only the security patches might lead to system library version change. The less versions change the less surprises, isn't it?
Should we re-build everything and re-publish patch versions of every java connector to clean out the vulnerabilities? Any good way to automate it? /cc @wennergr |
What
The
yum update
command occuring the java connector build pipeline is cached by dagger.This prevents benefittng from updated system packages which might get fixed vulnerabilities.
How
Bust the
yum update
layer on a daily basis.Pre-release
source-postgres
to check if less vulnerabilities are in a version with a freshyum update
Results
grype airbyte/source-postgres:latest
grype airbyte/source-postgres:3.4.13-dev.fcd46868de
Sounds like a win 🎉