Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: bust java build cache to fix vulnerabilities #39321

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jun 6, 2024

What

The yum update command occuring the java connector build pipeline is cached by dagger.
This prevents benefittng from updated system packages which might get fixed vulnerabilities.

How

Bust the yum update layer on a daily basis.

Pre-release source-postgres to check if less vulnerabilities are in a version with a fresh yum update

Results

grype airbyte/source-postgres:latest

1 critical, 12 high, 16 medium, 6 low, 0 negligible

grype airbyte/source-postgres:3.4.13-dev.fcd46868de

1 critical, 5 high, 6 medium, 0 low, 0 negligible

Sounds like a win 🎉

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 4:04pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/06-06-airbyte-ci_bust_java_build_cache_to_fix_vulnerabilities branch from f8b06ac to fcd4686 Compare June 6, 2024 15:31
@alafanechere alafanechere marked this pull request as ready for review June 6, 2024 16:02
@alafanechere alafanechere requested a review from a team as a code owner June 6, 2024 16:02
@alafanechere alafanechere force-pushed the augustin/06-06-airbyte-ci_bust_java_build_cache_to_fix_vulnerabilities branch from fcd4686 to c1fcb96 Compare June 6, 2024 16:04
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👊

@alafanechere alafanechere enabled auto-merge (squash) June 6, 2024 16:17
@alafanechere alafanechere merged commit c1ac66c into master Jun 6, 2024
30 checks passed
@alafanechere alafanechere deleted the augustin/06-06-airbyte-ci_bust_java_build_cache_to_fix_vulnerabilities branch June 6, 2024 16:23
Comment on lines -42 to +46
"yum update -y",
"yum update -y --security",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this update less things (only security) or more things (whatever we updated before AND security)?

Copy link
Contributor Author

@alafanechere alafanechere Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evantahler It updates less things (only security):

The --security parameter is important. Without it, yum update installs all updates, including bug fixes and enhancements.
(source)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But don't we want all the updates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I think I prefer to know that only the security patches might lead to system library version change. The less versions change the less surprises, isn't it?

@natikgadzhi
Copy link
Contributor

Should we re-build everything and re-publish patch versions of every java connector to clean out the vulnerabilities? Any good way to automate it? /cc @wennergr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants