Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Source Square: Add error handlers, migrate to inline schema and move spec #39377

Merged
merged 8 commits into from
Jun 11, 2024
Merged

🐛Source Square: Add error handlers, migrate to inline schema and move spec #39377

merged 8 commits into from
Jun 11, 2024

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Jun 10, 2024 •
edited
Loading

Closes airbytehq/PyAirbyte-Hackathon#11

Scenario:

While testing PyAirbyte with Source-Square, Some streams like loyalty made the whole connector fail even though other streams succeeded in syncing

Found issues:

No error handling when the source is not found - 404
No error handling when the source is forbidden - 403

Ref:
image

Proposing fix:

  • Add error handlers with 404, 403, 401, and 429 in rare cases of retry with exponential backoff due to rate limiting
  • Additionally, schemas were migrated inline and the spec is moved to manifest in light of making the connector compatible with the builder after the selective authenticator is supported in the builder in future

@vercel Vercel
Copy link

vercel bot commented Jun 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 2:25am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 10, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team June 10, 2024 17:26
@btkcodedev btkcodedev mentioned this pull request Jun 10, 2024
Closed
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Jun 11, 2024 •
edited
Loading

CI run successful - All green ✅
Ready to merge
image

marcosmarxm
marcosmarxm approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks a lot @btkcodedev

@marcosmarxm marcosmarxm merged commit f17a3cc into master Jun 11, 2024
31 of 32 checks passed
@marcosmarxm marcosmarxm deleted the btkcodedev/squareFixes branch June 11, 2024 19:36
xiaohansong pushed a commit that referenced this pull request Jun 14, 2024
@btkcodedev @xiaohansong
🐛Source Square: Add error handlers, migrate to inline schema and move…
4750f3d 
… spec (#39377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/square
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug issues with source-square connector
3 participants
@btkcodedev @marcosmarxm @octavia-squidington-iii