Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(google-ads): fix integration test; update acceptance tests #39425

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Jun 12, 2024

What

Update expected records for the click_view stream due to the error in the health report, as this stream has a retention time of 90 days. Fix integration tests by renaming the file. Add new stream to integration tests - topic_view.

User Impact

No user impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 7:53pm

@tolik0 tolik0 self-assigned this Jun 12, 2024
@tolik0 tolik0 marked this pull request as ready for review June 12, 2024 11:38
@tolik0 tolik0 requested a review from a team June 13, 2024 14:57
@tolik0 tolik0 changed the title chore(google-ads): update expected records for click_view stream test(google-ads): fix integration test; update acceptance tests Jun 13, 2024
@tolik0 tolik0 merged commit c29429d into master Jun 14, 2024
30 checks passed
@tolik0 tolik0 deleted the tolik0/source-google-ads/fix-expected-2024-06-12 branch June 14, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants