-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace AirbyteLogger with logging.Logger in connectors #40215
Conversation
- from airbyte_cdk import AirbyteLogger -> import logging - from airbyte_cdk.logger import AirbyteLogger -> import logging - logger: AirbyteLogger -> logger: logging.Logger - AirbyteLogger() -> logging.getLogger("airbyte") - airbyte-ci format fix all
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
853f2d0
to
73113b7
Compare
Hi, @alafanechere, Can you please review this PR |
@btkcodedev well, shit. Our tooling is so cool that there are already too many pull requests that are conflicting with this. We will have to open a new PR with these changes, bot on top of the fresh master. @alafanechere before we do so, let's confirm that this PR is OK in spirit. What @btkcodedev will do is:
At that point, it's a good idea to merge asap so we don't rack up new conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd 👍 this PR if it passed CI.
Multiple connectors are failing.
source-bing-ads
for instance is failing it's unit tests for reasons which look related to logging.
My suggestion is to:
- Remove from this branch all connectors not passing CI
- Then we can safely merge this one once CI is 🟢 (@btkcodedev you can add the
auto-merge
label to the PR once you've made this change) - Open per connector PR for the 🔴 one
- Manually inspect the failure reason of these 🔴 ones and use
/approve-and-merge
if they're definitely not related to the logger change.
Tooling wise the following flow can be followed to open per connectors PRs:
- Make batch logger changes on all remaining connectors
- Run
airbyte-ci connectors --modified bump-version patch "replace AirbyteLogger..."
- Run
airbyte-ci connectors --modified pull-request --message="Replace AirbyteLogger...
67f01b1
to
d5fc3ec
Compare
CI green for this branch |
Co-authored-by: btkcodedev <btk.codedev@gmail.com>
What
This commit does all the AirbyteLogger replacing in a single pass, without bumping connector versions. Here's why I did this (internal Slack).
The goal here is to take all connectors to be more ready to update, without spending a week on extra hoops. This change seems very safe and tactical.
This closes https://github.com/airbytehq/airbyte-internal-issues/issues/8406.
How
Replaces:
And then
airbyte-ci format fix all
.User Impact
None, connectors will not get republished.
Can this PR be safely reverted and rolled back?
Caveats
The CI on this will be very red because I'm changing connector code without bumping the version, so needs manual blessing from @alafanechere, @ChristoGrab, and @girarda.